Track fees for tradersdex #4459
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello @Tradersdex thansk for the PR. The field |
|
1.
1. It returns null because there weren't any trades in that
timeframe, the ts code checks that after and uses 0 for it.
const feeAmt =
Number(rows?.[0]?.fee_amount ?? 0) const protoAmt =
Number(rows?.[0]?.protocol_fee ?? 0) const creatorAmt =
Number(rows?.[0]?.creator_fee ?? 0) const solAmount =
Number(rows?.[0]?.sol_amount ?? 0) Otherwise I can change the
query to use
0 if that is preferred: SELECT COALESCE(SUM(sol_amount), 0) AS
sol_amount,
COALESCE(SUM(fee_amount), 0) AS fee_amount, COALESCE(SUM(creator_fee), 0)
AS creator_fee, COALESCE(SUM(protocol_fee), 0) AS protocol_fee
FROM decoded;
…On Wed, Oct 22, 2025 at 10:29 AM eden ***@***.***> wrote:
*noateden* left a comment (DefiLlama/dimension-adapters#4459)
<#4459 (comment)>
hello @Tradersdex <https://github.com/Tradersdex> thansk for the PR. The
field fee_amount is null from dune query. Can you check?
—
Reply to this email directly, view it on GitHub
<#4459 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BSTRZSTL2HK4BQ2WAZUSCXD3Y456RAVCNFSM6AAAAACJJENWISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMZRGA3TAOBZGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Tradersdex there is no activity from contract last 10 days. I'm not sure that protocol has make fees. I query and get 0 fees every day. Can you confirm? |
|
Yes
…On Thu, 23 Oct 2025 at 07:41, eden ***@***.***> wrote:
*noateden* left a comment (DefiLlama/dimension-adapters#4459)
<#4459 (comment)>
@Tradersdex <https://github.com/Tradersdex> there is no activity from
contract last 10 days. I'm not sure that protocol has make fees. Iquery and
get 0 fees every day. Can you confirm?
—
Reply to this email directly, view it on GitHub
<#4459 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BSTRZSU3JY2BHQLJN4LDPN33ZBTA3AVCNFSM6AAAAACJJENWISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMZVGE3TCMBSHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Because of no users activities, we will mark this PR as draft for now. We will open it once this project has activities. |
|
Will this be done automatically once we get some activity?
…On Thu, 23 Oct 2025 at 10:13, eden ***@***.***> wrote:
*noateden* left a comment (DefiLlama/dimension-adapters#4459)
<#4459 (comment)>
Because of no users activities, we will mark this PR as draft for now. We
will open it once this project has activities.
—
Reply to this email directly, view it on GitHub
<#4459 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BSTRZSRDBJ2A75XRAA2Y4W33ZCEZVAVCNFSM6AAAAACJJENWISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMZVGY3DSOJYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Tradersdex no, you need to get back and re-open this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
Please enable "Allow edits by maintainers" while putting up the PR.
poackage.json/package-lock.jsonfile as part of your changesName (to be shown on DefiLlama): Tradersdex
Twitter Link: https://x.com/tradersdex
List of audit links if any:
Website Link: Tradersdex.com
Logo (High resolution, will be shown with rounded borders): https://imgur.com/a/EiP1mFD
Current TVL: 0
Treasury Addresses (if the protocol has treasury)
Chain: Solana
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama): Discover fresh launches on Tradersdex—real-time charts, powerful filters, points for activity, and a seamless flow to create and launch your own token.
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one: Launchpad
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):